Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-6949] table filter does not hide empty headers #5353

Closed
wants to merge 1 commit into from

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Feb 14, 2014

@hieupham007
Copy link
Contributor

Functional failed. I'm getting a crash when changing orientation:
02-20 17:51:49.302: E/AndroidRuntime(29666): Caused by: java.lang.IllegalArgumentException: Wrong state class, expecting View State but received class android.widget.AbsListView$SavedState instead. This usually happens when two views of different type have the same id in the same hierarchy. This view's id is id/0x65. Make sure other views do not use the same id.
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.View.onRestoreInstanceState(View.java:12117)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.View.dispatchRestoreInstanceState(View.java:12093)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:2588)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:2588)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:2588)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:2588)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:2588)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.view.View.restoreHierarchyState(View.java:12071)
02-20 17:51:49.302: E/AndroidRuntime(29666): at com.android.internal.policy.impl.PhoneWindow.restoreHierarchyState(PhoneWindow.java:1634)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.app.Activity.onRestoreInstanceState(Activity.java:938)
02-20 17:51:49.302: E/AndroidRuntime(29666): at org.appcelerator.titanium.TiBaseActivity.onRestoreInstanceState(TiBaseActivity.java:1298)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.app.Activity.performRestoreInstanceState(Activity.java:910)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.app.Instrumentation.callActivityOnRestoreInstanceState(Instrumentation.java:1131)
02-20 17:51:49.302: E/AndroidRuntime(29666): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2158)
02-20 17:51:49.302: E/AndroidRuntime(29666): ... 12 more

This crash does not appear on master. Tested on 4.2.2 Galaxy Nexus

@hieupham007
Copy link
Contributor

any update?

@bijupmb
Copy link
Contributor Author

bijupmb commented Mar 14, 2014

This issue cannot reproduce .Tested on Device: Samsung galaxy s duos Android version: 4.0.4. and Samsung s3 Android version: 4.3

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 4, 2014

let me check . now I am getting this error .

@negupta
Copy link
Contributor

negupta commented Apr 17, 2014

@bijupmb What is the status of this PR? There has been no update for 2 weeks now.

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 21, 2014

This problem is getting in latest master also.The cause of this issue is
"listView.setId(TI_TABLE_VIEW_ID);". I am looking into this.

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 25, 2014

shall we use listView.setId(android.R.id.list); instead of listView.setId(TI_TABLE_VIEW_ID) ?

@negupta
Copy link
Contributor

negupta commented Apr 28, 2014

@hieupham007 - Please address his question.

@hieupham007
Copy link
Contributor

Biju, since this is working with master, the id isn't what's causing the crash.

@hieupham007
Copy link
Contributor

Please also merge with master

@bijupmb
Copy link
Contributor Author

bijupmb commented May 1, 2014

ok start merging

@bijupmb
Copy link
Contributor Author

bijupmb commented May 8, 2014

Get same error in master. Did you check ?

@hieupham007
Copy link
Contributor

PR doesn't fix the problem, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants