[TIMOB-16080] Removes (Annoying) touch sound that are on EVERY view. #5373
Conversation
Only views that are touchable (click event) should have a touch sound. Touch sounds on everything lead to a very confusing user experience.
|
+1 Please merge this once the conflicts have been resolved. Are there side effects or some downside to this that isn't obvious? |
|
@gstreetmedia Are you able to resolve the merge conflicts? Jira for ref: https://jira.appcelerator.org/browse/TIMOB-16080 |
|
Closing this PR for now, since the merge conflicts have not been resolved over the last 6 months and the CLA is not signed. Feel free to open a new PR to the master and we can review it. Thanks! |
|
I'm pretty sure I signed the CLA jeff sent me two years ago. |
|
We migrated that process a while ago to incorporate with Github. Please also make sure to resolve the merge conflicts. Will reopen, you can sign it http://cla.appcelerator.com. Thanks! |
| //If touchEnabled is specifically set, enable or disable touch sound | ||
| touchable.setSoundEffectsEnabled(clickable); | ||
| } else { | ||
| touchable.setSoundEffectsEnabled(false); |
There was a problem hiding this comment.
By making this change, it would change the default (native) behavior. I'm good with deactivating the sound when touches are not enabled, but it shouldn't change the default behavior. What do you think?
There was a problem hiding this comment.
I'm not sure. The default behavior of TI is that touch sounds are enabled on every kind of view, no matter whether or not that view has any kind of touch / click event applied to it. This not the default behavior in native-built applications. If you don't do this is some kind of global fashion, then you would have to apply this setting to every nested element of a view. Say a view in comprised of three additional views, all without interactivity, then you would specifically have to apply touchEnabled = false to each and every view. To make matters worse, on iOS setting touchEnabled = false on a parent view, would disable interactive events on all child views (not true in Android). As such, this was the only feasible place I could think / find to implement this logic.
The only way a developer has to make this choice currently is styles.xml, which is an all or nothing proposition.
<style name="AppTheme" parent="AppBaseTheme"> false </style>There was a problem hiding this comment.
@ashcoding, your thoughts?
There was a problem hiding this comment.
i'd be fine to disable it for 6.0 (accept the suggested PR) and just make a ti flag in tiapp.xml which allows you to revert to previous behavior.
There was a problem hiding this comment.
Alright. So let's introduce the property <property name="ti.android.soundEffectsEnabled" type="bool" /> in the naming convention like ti.android.bug2373.finishfalseroot and merge this PR. @gstreetmedia can you apply this late change? If not, we would get an Android engineer of our team on it and merge this before. Thanks in advance!
|
Closing in favor of #8816 🚀 |
Touch sounds on everything lead to a very confusing user experience.
This changes behavior such that all views will have no touch sound (by default), but those views which are specifically set as touchEnabled = true will have the touchsound.