[TIMOB-8930] MobileWeb: Ti.UI.View.rect not updated after animation #5375
Conversation
| @@ -423,6 +423,7 @@ define(['Ti/_/declare', 'Ti/_/Evented', 'Ti/_/style', 'Ti/UI'], function(declare | |||
|
|
|||
| promise.pause = function() { | |||
| var a = findAnimation(); | |||
| updateRect(a.elem); | |||
There was a problem hiding this comment.
We notice updateRect() is called multiple times. Is there a reason it can't be called once?
There was a problem hiding this comment.
I do recall there being some reason for this. However, I made this modification over a year ago, so I'm not quite sure what the reason was. I know at least one reason was that KineticScroll views are completely broken without this fix. Stopping a scrollview mid scroll, lead to that scroll view reverting to it's original position.
Everytime I look at Animation.js I want to start from scratch, letting the browser (and thus the GPU) do all the heavy lifting. It seems like we could eliminate more than 50% of the code and get a huge performance boost by using CSS-based animation rather than tweening the transform property.
Does Appcelerator by chance maintain any kind of documentation regarding the inner workings of mobile web?
|
If you are still interested in this addition, please let us know and we'd be happy to work with you on updating it. |
|
Closing this PR, since we couldn't get a response on the code review. |
Needed to read and parse the current translation.