[TIMOB-16487] remove support for navbar-hidden #5377
Conversation
|
The CLI build script needs to be updated as well. It's probably why FR failed: Toggling the false property in the tiapp.xml still enables/disables the nav-bar |
|
Addressed comments |
| } | ||
| if (this.tiapp.fullscreen || this.tiapp['statusbar-hidden'] ) { | ||
| flags += '.Fullscreen'; | ||
| } |
There was a problem hiding this comment.
There are other places where 'navbar-hidden' needs to be removed in the build scripts. If you search for 'navbar-hidden', you will find the references.
|
Code reviewed, found a number of places where the navbar logic was not removed. Please grep for navbar inside the code base and remove them accordingly. |
|
FR failed. The navbar still shows up with the following set in tiapp.xml: |
|
The title bar is still visible. We simply remove the ability to hide it, since it's irrelevant with actionbar. |
|
Code reviewed and functionally tested. Request Accepted. |
[TIMOB-16487] remove support for navbar-hidden
[TIMOB-16487] remove support for navbar-hidden
testing steps in JIRA.