[TIMOB-16508] Scale bitmap if too large to load into texture. #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,6 +291,7 @@ public Bitmap getBitmap() | |||
| * If decode fails because of the odd Android 2.3/Gingerbread behavior (TIMOB-3599), retry loading the original image. | |||
| * This method should be called from a background thread when needRetry is set to true because it may block | |||
| * the thread if it needs to retry several times. | |||
| * If bitmap's size exceeds GL allowance of 2048x2048 (this may happen when taking a photo), scale it with respect to ratio. | |||
There was a problem hiding this comment.
2048 is not fixed. This is actually device dependent (GL_MAX_TEXTURE_SIZE). The S4 I am testing on reports limit to be 4096. And 2048 might still be too large on old devices.
Also if you really want to scale down an image by default, it might be easier to set the inSampleSize irrespective of the needRetry parameter. You can get size of bitmap by passing inJustDecodeBounds and adjusting inSampleSize initially
|
The PR will work but makes assumptions that are incorrect. Please address comments |
|
We already have methods to resize images. Developers should not be loading Camera images directly into memory without resizing. Going to mark the ticket as Wont Fix. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA