[TIMOB-16353] Use TiTranslucentActivity if the backgroundcolor is transpar... #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parent or has alpha
| @@ -350,6 +351,11 @@ private void fillIntent(Activity activity, Intent intent) | |||
| } | |||
| if (!modal && hasProperty(TiC.PROPERTY_OPACITY)) { | |||
| intent.setClass(activity, TiTranslucentActivity.class); | |||
| } else if (hasProperty(TiC.PROPERTY_BACKGROUND_COLOR)) { | |||
| Integer bgColor = TiConvert.toColor(properties, TiC.PROPERTY_BACKGROUND_COLOR); | |||
There was a problem hiding this comment.
return type for this method is int not Integer
|
Code Reviewed. Please address comments |
|
Addressed review comments |
|
Code Reviewed. ACCEPTED |
|
Functional Passed. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Mar 7, 2014
[TIMOB-16353] Use TiTranslucentActivity if the backgroundcolor is transpar...
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-16353] Use TiTranslucentActivity if the backgroundcolor is transpar...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TiTranslucentActivity if the backgroundcolor is transparent or has alpha
https://jira.appcelerator.org/browse/TIMOB-16353