Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-16122] set rotation to match orientation for Camera #5392

Closed
wants to merge 1 commit into from

Conversation

hieupham007
Copy link
Contributor

testing steps in JIRA.

@vishalduggal
Copy link
Contributor

So our current implementation sets the camera display orientation based on screen orientation and now we are trying to do the same camera parameter rotation.

Both of these values are supposed to be based on the camera info. See sample code in Android docs and refactor for correct behavior and support of front facing camera.

@philsmithsonuk
Copy link

Thanks @hieupham007 , this was good enough for what we needed :)

@vishalduggal
Copy link
Contributor

This PR failed function. Anyways alternate PR is up. PR #5597
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants