TIMOB-15551-make sure that the view is set in the proxy #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -649,6 +649,7 @@ public void generateChildContentViews(DataItem item, TiUIView parentContent, TiB | |||
| TiViewProxy proxy = child.getViewProxy(); | |||
| TiUIView view = proxy.createView(proxy.getActivity()); | |||
| view.registerForTouch(); | |||
| proxy.setView(view); | |||
There was a problem hiding this comment.
This will affect every proxy and every view, not just ImageView. Did you run KS to make sure no regressions on ListView?
There was a problem hiding this comment.
I will run KS tomorrow.
There was a problem hiding this comment.
I ran KS and everything looks ok.
|
Code Reviewed. ACCEPTED |
|
FR Passed. Tested on S3 running 4.3. Also regressed KS ListView. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Mar 6, 2014
TIMOB-15551-make sure that the view is set in the proxy
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
TIMOB-15551-make sure that the view is set in the proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that the view is set in the proxy so that new view is not created when .start is called on the ImageViewProxy.
https://jira.appcelerator.org/browse/TIMOB-15551