[TIMOB-1356] setUrl in AudioPlayer not working #5427
Conversation
| mp.setOnCompletionListener(this); | ||
| mp.setOnErrorListener(this); | ||
| mp.setOnInfoListener(this); | ||
| mp.setOnBufferingUpdateListener(this); | ||
|
|
||
| setState(STATE_INITIALIZED); |
There was a problem hiding this comment.
why are you add these lines here?
There was a problem hiding this comment.
I just create a method from the existing code .
There was a problem hiding this comment.
This is incorrect. The state is set at line 105. Why are you setting it again here?
|
Code reviewed.Please address comments |
|
@bijupmb There has been no update on this PR for over a month now. We should follow up proactively on these PR comments. |
|
I am waiting for reply for addressed comment "I just create a method from the existing code " |
|
@hieupham007 - Please review his comment. I am not sure what he means though. |
|
I extract method from an existing code |
|
Biju, the state is already set at line 105, please look at my comment |
|
Done |
|
@hieupham007 Can you please review the code changes? |
https://jira.appcelerator.org/browse/TIMOB-1356