Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-16277] Removed ASI from Titanium SDK #5456

Merged
merged 3 commits into from Mar 12, 2014

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Mar 11, 2014

No more dependencies on ASIHTTPRequest!!
Details in Jira ticket

@vishalduggal
Copy link
Contributor

Functional failed.

KS->Platform->XHR->UTF8 tests

@pec1985
Copy link
Contributor Author

pec1985 commented Mar 11, 2014

The example in Kitchen Sink is wrong and needs to be fixed.
Passing parameters to the .send() can only be done if the method is POST, otherwise the request will fail.
If, on the other hand, the method is GET, the parameters need to be appended at the end of the url like so: http://example.com?name=pedro&lastname=enrique
For more information, click here

This is different from the old HTTPClient which allowed this behavior. This change is for the best and the old way is wrong, all according to the documentation link provided a couple of lines above.

@vishalduggal
Copy link
Contributor

FR ok. KS passed without any problems with the exception stated above.
Merging.

vishalduggal added a commit that referenced this pull request Mar 12, 2014
[TIMOB-16277] Removed ASI from Titanium SDK
@vishalduggal vishalduggal merged commit 99bd38e into tidev:master Mar 12, 2014
farfromrefug pushed a commit to Akylas/titanium_mobile that referenced this pull request Aug 15, 2014
[TIMOB-16277] Removed ASI from Titanium SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants