timob-13864: add support for maps inside actionbar tab #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void setContentView(View view) { | ||
| contentView = view; | ||
| public TabFragment(TiUIActionBarTab tab) { | ||
| this.tab = new WeakReference<TiUIActionBarTab>(tab); |
There was a problem hiding this comment.
There is no need for weak references for the Tab.
|
Code Reviewed. Please address comments |
|
Code Reviewed. There is an unused import which needs to be removed. Otherwise ok. Continuing with FR |
|
CR + FR ok. Was able to reproduce fail case and verify solution. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Mar 20, 2014
timob-13864: add support for maps inside actionbar tab
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
timob-13864: add support for maps inside actionbar tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA