[TIMOB-16275] iOS Cookie management #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…props and methods
| platforms: [iphone, ipad] | ||
| since: "3.3.0" | ||
| returns: | ||
| type: String |
There was a problem hiding this comment.
String??Also what happens if I call this method on a cookieProxy created from a cookie that already exists in the system? When creating a cookie what values are required for a cookie to be valid
|
Code Reviewed. REJECTED |
| { | ||
| if(self = [super _initWithPageContext:context]) | ||
| { | ||
| for(NSString *key in [cookie properties]) |
There was a problem hiding this comment.
_cookieDict = [[NSMutableDictionary dictionaryWithDictionary:[cookie properties]] retain]
There was a problem hiding this comment.
httpOnly = [cookie isHttpOnly] and modify the getter for iSHttpOnly to use this boolean
| summary: Returns true if the cookie is valid. | ||
| description: | | ||
| This method checks wheather the cookie is valid. For a cookie to be valid the | ||
| minimum properties requiered are `domain`, `name`, `value`, and `path` |
There was a problem hiding this comment.
Actually on iOS you need path, name,value and either domain or original Url
|
Code Reviewed. ACCEPTED |
|
FR ok. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Mar 18, 2014
[TIMOB-16275] iOS Cookie management
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-16275] iOS Cookie management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in Jira ticket
Test case here