TIMOB-4482 Android: For TabGroup, put tabHost in a TiCompositeLayout so as to support position animation beyond screen size #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support position animation beyond screen size.
|
Code reviewed, functional tested. Performs the same as 1.6.2. Request Accepted |
|
Code reviewed. Request Accepted |
donthorp
added a commit
that referenced
this pull request
Oct 18, 2011
TIMOB-4482 Android: For TabGroup, put tabHost in a TiCompositeLayout so as to support position animation beyond screen size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-4482
test case is the fail case app.js in the JIRA item. When you tap the button the TabGroup should animate up/down (except for the very first time you tap the button, which doesn't do anything because of the way the test is written.)