[TIMOB-13301] iOS support moveNext and movePrevious methods #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,12 +38,14 @@ methods: | |||
| - name: moveNext | |||
| summary: | | |||
| Sets the current page to the next consecutive page in <Titanium.UI.ScrollableView.views>. | |||
There was a problem hiding this comment.
We should specify that this will set the next page with an animation
|
Code reviewed. Added comments. |
|
PR reviewed and tested. APPROVED! |
pec1985
added a commit
that referenced
this pull request
Apr 8, 2014
[TIMOB-13301] iOS support moveNext and movePrevious methods
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-13301] iOS support moveNext and movePrevious methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the moveNext and movePrevious methods to Ti.UI.ScrollableView on iOS
This PR also brings parity to the scrolling behavior of ScrollableView on programmatically changing the current page in iOS and Android. The behavior is as follows
currentPage property - Non Animated Scroll
moveNext,movePrevious,scrollToView methods - Animated Scroll
Test is attached to JIRA TICKET