Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-13347] Added code-processor toXML serialization to tiapp.xml lib. #5572

Merged
merged 1 commit into from Apr 6, 2014
Merged

[TIMOB-13347] Added code-processor toXML serialization to tiapp.xml lib. #5572

merged 1 commit into from Apr 6, 2014

Conversation

cb1kenobi
Copy link
Contributor

No description provided.

@ayeung
Copy link
Contributor

ayeung commented Apr 6, 2014

FR failing for me:

/Users/ayeung/titanium/titanium_mobile/node_modules/titanium-sdk/lib/titanium.js:27
exports.targetPlatforms = manifest.platforms.map(function (p) {
                                             ^
TypeError: Cannot call method 'map' of undefined
    at Object.<anonymous> (/Users/ayeung/titanium/titanium_mobile/node_modules/titanium-sdk/lib/titanium.js:27:46)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/ayeung/titanium/titanium_mobile/node_modules/titanium-sdk/tests/test-tiappxml.js:1:72)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

@cb1kenobi
Copy link
Contributor Author

You need to run it from the SDK folder. It tries to load the manifest.json file which doesn't exist in the git repo.

@ayeung
Copy link
Contributor

ayeung commented Apr 6, 2014

Code reviewed and functionally tested. Request Accepted.

ayeung pushed a commit that referenced this pull request Apr 6, 2014
[TIMOB-13347] Added code-processor toXML serialization to tiapp.xml lib.
@ayeung ayeung merged commit f29e8f0 into tidev:master Apr 6, 2014
@cb1kenobi cb1kenobi deleted the timob-13347 branch April 7, 2014 04:09
farfromrefug pushed a commit to Akylas/titanium_mobile that referenced this pull request Aug 15, 2014
[TIMOB-13347] Added code-processor toXML serialization to tiapp.xml lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants