TC-4029: normalize tab selection/unselection cross-platform, and keyboard hiding improvement #5636
Conversation
…droid, and improve keyboard hiding in Android
|
See the test app in the JIRA issue: https://jira.appcelerator.org/browse/TC-4029 |
| if ([self _hasListeners:@"blur"]) { | ||
| [self fireEvent:@"blur" withObject:nil withSource:self propagate:NO reportSuccess:NO errorCode:0 message:nil]; | ||
| if ([self _hasListeners:@"unselected"]) { | ||
| [self fireEvent:@"unselected" withObject:nil withSource:self propagate:NO reportSuccess:NO errorCode:0 message:nil]; |
There was a problem hiding this comment.
In iOS the tab focus/blur events functioned as selection indicators, so we renamed them to match the Android selected/unselected events.
|
As a side note: in Android the entire TabGroup implementation is needlessly complicated, perhaps since prior to 3.3.0 we had to deal with two different types of TabGroups. The entire implementation can use a serious cleanup sometime in the future. However, this PR is urgently needed now. |
|
done :) On Sun, Apr 27, 2014 at 2:11 AM, mokesmokes notifications@github.comwrote:
Thank you. Mitul Bhalia, |
|
@mitulbhalia lol, and this one too :) |
|
Closed due to the new swipe tabs PR: #5651 |
Prior to this PR, in Android we had no reliable event for tab selection and unselection. The tab focus and blur events would fire in these cases, but as the JIRA issue shows they also fired under additional circumstances as well. In order to not mess with the (rather complex!!!) focus/blur bubbling logic in Titanium Android (and not break existing apps), this PR simply added the
selectedandunselectedevents for tabs (with the additional benefit of the clearer event name than focus and blur).In iOS, the
focusandblurevents functioned exactly as tab selection indicators, and there was no bubbling event confusion in their case between window, tab, and tab group. However, to be compatible with Android these events were renamed toselectedandunselected. The tabfocusandblurevents have been removed for iOS.Additionally, in Android the keyboard is now hidden when the tab selection changes, and not when the tab loses focus (e.g. when the screen is locked), providing for a much smoother user experience.