[TIMOB-11671] Clear out unrequired variables at end of run #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed. Verified that this did not break the test case in TIMOB-11671. I was never able to reproduce the original test case, so I could not verify that this fix resolved the issue. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
May 12, 2014
[TIMOB-11671] Clear out unrequired variables at end of run
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-11671] Clear out unrequired variables at end of run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things.
I could not reproduce the memory leak as reported in the ticket, though I did see the memory grow which is probably due to XML processing. This is more of a clean up PR to ensure there are no clients in memory when instances of TiHttpClient are GCed.
JIRA TICKET