Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-15594-Used Base64OutputStream to encode #5677

Merged
merged 1 commit into from May 23, 2014

Conversation

salachi
Copy link
Contributor

@salachi salachi commented May 13, 2014

Used Base64OutputStream to properly encode the bytes.

https://jira.appcelerator.org/browse/TIMOB-15594

@hieupham007
Copy link
Contributor

Still getting the broken pipe error with this fix (with tryTheFix = true) with movie.mp4. I'll upload that to the ticket.

@salachi
Copy link
Contributor Author

salachi commented May 14, 2014

I think it is because the file is too big and the connection is open for long, there is a good chance that connection may be interrupted. I got the same error once but when I ran it again, it succeeded.

@hieupham007
Copy link
Contributor

Sunil, so this is a won't fix and dependent on the file size? Why do we have that limitation?

@salachi
Copy link
Contributor Author

salachi commented May 15, 2014

Hieu, this is not our limitation, it is the reliability of the connection and that is why some times it work. If the connection is open for a long time, there is more chance that it may get interrupted either by the server or due to network issues. I think if we setup a local server, we won't see this problem.

@hieupham007
Copy link
Contributor

Sunil, I tried it with a local server, while I didn't get any broken pipe error, I got this:
[INFO] : onLoad:Source=tixhr1936686761.mp4
Destination=temp/
Target path=../htdocs/temp/tixhr1936686761.mp4
Size=3443671
There was an error uploading the file, please try again!

@hieupham007
Copy link
Contributor

Ok looks like you need to manually create the temp/ folder for this to work. Looks good. Merging

hieupham007 added a commit that referenced this pull request May 23, 2014
TIMOB-15594-Used Base64OutputStream to encode
@hieupham007 hieupham007 merged commit 71aff57 into tidev:master May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants