Timob 16918 3 3 x #5713
Merged
Timob 16918 3 3 x #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hieupham007 please format your JIRA ticket numbers in the commit message so they follow the normal convention: |
|
@jhaynie I agree it should be updated so that the JIRA will index the commit properly, but I believe the format is TIMOB-16918 according to our guides: https://wiki.appcelerator.org/display/guides2/Pull+Request+Guide#PullRequestGuide-9.SubmitpullrequestinGithub. |
|
CR + FR ok. APPROVED |
|
@jhaynie Oops, must have missed this comment. Ok, will do next time. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA