[timob-16893]: Android update doc and behavior for 'enableReturnKey' property #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieupham007
changed the title
| enableReturnKey = TiConvert.toBoolean(proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY), false); | ||
| } | ||
| if (enableReturnKey && v.getText().length() == 0) { | ||
| return true; |
There was a problem hiding this comment.
If we do this we can never enter the newline as the first character in TextArea
There was a problem hiding this comment.
This is already the case in the current codebase, I only move this check up so we don't fire the return event. I think this is correct behavior since the docs for TextArea says: If true, the return key is disabled when this text area is empty, and automatically enabled as soon as the user types any text in the area.
|
CR + FR ok. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Jul 29, 2014
[timob-16893]: Android update doc and behavior for 'enableReturnKey' property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA