TIMOB-5819: Android: Percentage-based views need to be re-drawn on device rotation #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Use the height and width from params if we can. When we switch orientation the child returns the | ||
| // value from the previous orientation instead of the current one | ||
| int childMeasuredWidth = params.optionWidth != null ? params.optionWidth.getAsPixels(this) : child |
There was a problem hiding this comment.
does this also account for width: "auto" ?
|
Request Accepted: |
|
Request Accepted: |
|
Code review accepted |
|
Code review and functional test accepted. Tested with HTC Desire (Android 2.2). Used both test cases from the ticket. Also changed those test cases to use windows without tabgroups, and then lightweight windows as well. All performed the same. Also went through several screens of KitchenSink to make sure nothing broken, and ran the ui, ui.controls and android.ui drillbit tests, all successfully. |
billdawson
added a commit
that referenced
this pull request
Oct 25, 2011
TIMOB-5819: Android: Percentage-based views need to be re-drawn on device rotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-5819
Test cases are in Jira ticket.