TIMOB-5748 Android: rip out rhino commonjs as it requires compiled modules which cannot be easily debugged #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n context. Was accidentally executing it always in the root context." This reverts commit 945455c.
…e handled." This reverts commit e0a60fa.
…re it should have been in the first place. Good catch ayeung!" This reverts commit 8746e2c.
…ss it on!" This reverts commit 29ea073.
…o that if the call to Rhino require indeed returns an object. Else just return what it gives back." This reverts commit c5c9db2.
…() be a Scriptable" This reverts commit 4388db8.
…sting in TiScriptRunner, make KrollContext implement ModuleScriptProvider rather than making an anonymous instance of it, to save from putting one more class into the dex." This reverts commit adfccf3.
This reverts commit a508517.
This reverts commit 85e0dd4.
This reverts commit 1cccac7.
…s implementation so that breakpoints can be hit and so that JS modules can successfully require() native modules.
…ng slashes and that the correct ti context is used when executing a common js module.
| Scriptable scope = context.newObject(jsScope); | ||
| Scriptable exports = context.newObject(scope); | ||
| scope.put("exports", scope, exports); | ||
| Log.d(LCAT, "Running CommonJS module script: " + relativePath); |
… file so that it only occurs in non-compiled mode.
|
Code reviewed. Request Accepted |
|
Request Accepted |
|
Code reviewed and functionally tested. Request Accepted |
donthorp
added a commit
that referenced
this pull request
Oct 25, 2011
TIMOB-5748 Android: rip out rhino commonjs as it requires compiled modules which cannot be easily debugged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main item:
http://jira.appcelerator.org/browse/TIMOB-5748
Testing for the main item is the failcase described in the ticket.
Then these items have been re-opened to be re-tested because they were originally done with the Rhino commonjs and need to tested with the different require() implementation:
TIMOB-5123 <-- link is directly to testing notes.
TIMOB-5434 -- test is precisely the failcase in that ticket.
Sorry for the multiple items to test/resolve, but this change really requires it.