[TIMOB-17136]iOS: HttpClient public setters should accept null #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| -(void)setOnload:(id)callback | ||
| { | ||
| ENSURE_SINGLE_ARG(callback, KrollCallback) | ||
| ENSURE_SINGLE_ARG_OR_NIL(callback, KrollCallback) | ||
| [self replaceValue:callback forKey:@"onload" notification:NO]; | ||
| hasOnload = YES; |
There was a problem hiding this comment.
If callback is nil, then hasOnload needs to be NO That flag is used to tell the program to fire the callback in the request:onLoad: function.
|
That comment I left applies to all the other changes as well. Please address comments before I merge. |
|
PR reviewed, code tested. APPROVED! |
pec1985
added a commit
that referenced
this pull request
Jun 13, 2014
[TIMOB-17136]iOS: HttpClient public setters should accept null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case in JIRA