[TIMOB-17166] [TC-4136] (3_3_X) Code cleanup #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also address https://jira.appcelerator.org/browse/TIMOB-16924 (TC-4136 is a dupe of that) |
|
No. The issues were incorrectly marked as duplicates. TIMOB-16924 is still awaiting a test case. |
|
Code Reviewed , FR-ed and approved |
srahim
added a commit
that referenced
this pull request
Jun 19, 2014
[TIMOB-17166] [TC-4136] (3_3_X) Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry Pick PR #5810 and PR #5804 into 3_3_X