TIMOB-16134-make sure that exception is caught while calling isPlaying #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Reviewed and ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
Jul 23, 2014
TIMOB-16134-make sure that exception is caught while calling isPlaying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-16134
Looking at the Android source for mediaplayer, the error message about "subtitle controller" is just a information message saying that the subtitle controller is not set and doesn't cause any problem. The real issue is correctly described in TC-4236. If the timer event get executed during media player is releasing, calling isPlaying will throw IllegalStateException as described in the Android documentation.
The changes are
Just like in other places, handle the exception while calling isPlaying.
Stop the progress timer in 'onDestroy' and 'release' before media player is released.