Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17285] CloudPush: updating to v3.3.0 #5890

Merged
merged 2 commits into from Jul 8, 2014

Conversation

jonalter
Copy link
Contributor

@jonalter jonalter commented Jul 8, 2014

No description provided.

@negupta
Copy link
Contributor

negupta commented Jul 8, 2014

We should keep the version as 3.3.0 for this release.

@jonalter
Copy link
Contributor Author

jonalter commented Jul 8, 2014

@negupta The reason I bumped it is because we have had a few instances recently where QE was actually testing against an older version of a module because I made and update and didn't bump the version. When the sdk installs it does not overwrite modules that are already there. The workaround for this issue is to delete the version of the module that is shipped with the sdk before installing the sdk. Also, I thought it would avoid confusion to bump the version.

If you would still like me to roll the version back to 3.3.0, I am happy to do so.
Please let me know.

@jonalter
Copy link
Contributor Author

jonalter commented Jul 8, 2014

Also, the list of modules that we are shipping with 3.3.0 are here: https://github.com/appcelerator/titanium_releases/blob/3_3_X/titanium.json#L9-L16
ti.cloudpush is the only one that happens to have a version that is close to 3.3.0

@ayeung
Copy link
Contributor

ayeung commented Jul 8, 2014

Code reviewed and functionally tested. Request Accepted.

ayeung pushed a commit that referenced this pull request Jul 8, 2014
[TIMOB-17285] CloudPush: updating to v3.3.1
@ayeung ayeung merged commit 2ca4bff into tidev:3_3_X Jul 8, 2014
@jonalter jonalter deleted the TIMOB-17285-3_3_X branch July 8, 2014 20:27
@ingo ingo changed the title [TIMOB-17285] CloudPush: updating to v3.3.1 [TIMOB-17285] CloudPush: updating to v3.3.0 Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants