[TIMOB-1618] Android: Label property minimumFontSize not implemented #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added minimumFontSize property with the same behaviour as on iPhone
Added property minimumFontSize
Implemented parity behaviour for the property minimumFontSize on Android.
Correction: replaced missing font padding implementation
Added import declarations.
ingo
changed the title
| /** | ||
| * @module.api | ||
| */ | ||
| public static final String PROPERTY_MINIMUMFONTSIZE = "minimumFontSize"; |
There was a problem hiding this comment.
Might want to change PROPERTY_MINIMUMFONTSIZE to PROPERTY_MINIMUM_FONT_SIZE to more align with Appcelerator's coding style.
|
@lgolu Can you address the comment above and update the repo to work with the latest master? Its a great addition to the SDK so we would appreciate it as part of the core. Thank you! |
Renamed PROPERTY_MINIMUM_FONT_SIZE
Renamed PROPERTY_MINIMUM_FONT_SIZE
|
@lgolu Thanks for addressing the comments! Can you please pull from master to resolve the merge conflicts? If not, we can do that for you of course. Then @fmerzadyan can check the CR and FT. Thanks! |
|
@hansemannn It would be great if you could resolve the merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've resolved the parity ticket for minimumFontSize property of the Label on Android (https://jira.appcelerator.org/browse/TIMOB-1618).
If the property is set it scales the text to fit, same behaviour as on iPhone. It was tested with the Titanium app I'm working on at Atoss, cannot publish testing code.