TIMOB-4357: Webview fatal exception / crash on re-open #594
Conversation
| webView.changeProxyUrl(url); | ||
| if (DEFAULT_PAGE_FINISH_URL.equals(url)) { | ||
| url = ""; | ||
| webView.getProxy().getProperties().remove("url"); |
There was a problem hiding this comment.
we should actually check for parity with iOS in this case. What do they do with the "url" property of the event that fires when a page is loaded, in the case where the page is loaded via setHtml rather than a true url? Also, check to see what they do with the proxy "url" proerty in this case. We're removing it here (my suggestion) but maybe they do something diff.
There was a problem hiding this comment.
Just tested in iOS and the url is set to "app://com.iphone/(null)" when we use setHtml rather than a true url.
|
Functional test passed. Waiting on parity issue check for code review. |
|
Code review accepted |
|
Code review and functional test accepted. Did functional both for this ticket and timob-1936, both in rhino and v8. |
TIMOB-4357: Webview fatal exception / crash on re-open
http://jira.appcelerator.org/browse/TIMOB-4357
Test case should be here
This ticket should be tested as well: timob-1936