[TIMOB-17456]: Treat 'null' values as '' for searchableText #5949
Conversation
| //Handle case sensitivity | ||
| if (caseInsensitive) { | ||
| searchText = searchText.toLowerCase(); | ||
| searchableText = searchableText.toLowerCase(); | ||
| } | ||
| //String comparison | ||
| if (searchableText != null && searchableText.contains(searchText)) { | ||
| if (searchableText.contains(searchText)) { |
There was a problem hiding this comment.
Will it crash if searchableText is null?
There was a problem hiding this comment.
No, that's handled above, converting null to ""
There was a problem hiding this comment.
What if searchableText is null and searchText is ""? I think when searchableText is not specified, it means the search functionality is not enabled. No matter you want to show all the items or hide all the items in this case, you can treat this is a special situation and take care of it at the beginning so it does not need to go through all the following logic and code.
There was a problem hiding this comment.
Ok, I will initialize searchableText to "" instead of null.
|
Ran the test case with this fix. The app still crashed. |
|
CR and FR passed. Accepted |
[TIMOB-17456]: Treat 'null' values as '' for searchableText
testing steps in JIRA