New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-16185-Use GZipInputStream if the cached content is gzip #5985
Conversation
|
||
protected String getHeader(Map<String, List<String>> headers, String header) | ||
protected static String getHeader(Map<String, List<String>> headers, String header) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change it to static method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am calling getHeader from the static function openCachedStream also.
Sunil, please address Ping's comment |
Sunil, can you merge the PR with master? |
@@ -302,6 +319,18 @@ public CacheResponse get(URI uri, String rqstMethod, | |||
} | |||
|
|||
// Read in the headers | |||
Map<String, List<String>> headers = readHeaders(hFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if it throws IOException?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NV.
Code reviewed and functionally tested. Accepted |
TIMOB-16185-Use GZipInputStream if the cached content is gzip
If the cached content is 'gzip', wrap the stream with GZipInputStream to properly unzip the content.
https://jira.appcelerator.org/browse/TIMOB-16185