TC-4653 : Add access to iOS App Setting URL #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add access to the iOS8 UIApplicationOpenSettingsURLString. This allows the developer to launch directly into the iOS8 App Settings Screen using Ti.Platform.canOpenURL.
For example:
~~~
var settingsURL = Ti.App.iOS.ApplicationOpenSettingsURL;
if(settingsURL!=undefined){
if(Ti.Platform.canOpenURL(settingsURL)){
Ti.Platform.openURL(settingsURL);
}else{
alert('cannot open URL');
}
}
~~~
|
Hi Ben, code looks good and tested. Note in sample code, it should be Ti.App.iOS.applicationOpenSettingsURL, with a small a for applicationOpenSettingsURL. |
|
@benbahrenburg Yeah, @cheekiatng is right with the case sensitivity. This would be on par with |
|
@cheekiatng documentation added to the PR |
| description: | | ||
| Used to create a URL that you can pass to the [openURL](Titanium.Platform.openURL) method. | ||
| When you open the URL built from this string, the system launches the Settings app and displays the app’s custom settings, if it has any. | ||
|
|
There was a problem hiding this comment.
Description looks good. But line 259 to line 263, remove the 'tabs', the doc generator will fail when 'tabs' are encountered. In github, you can 'view whole file' and you will see what i mean.
|
Doc formatting issues fixed. Thanks for the PR @benbahrenburg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add access to the iOS8 UIApplicationOpenSettingsURLString. This allows the developer to launch directly into the iOS8 App Settings Screen using Ti.Platform.canOpenURL.
For example: