[TIMOB_17601] Added ioslib 0.2.9 which fixes handling of launch timeouts... #6173
Conversation
…uts and added extra debugging output. The default launch timeout is now 3 minutes which should be large enough for users launching an iOS 8 simulator on a really old, slow Mac. Added 'ios.simTimeout' config option to override the 3 minute default.
| @@ -313,7 +313,7 @@ function detect(options, callback) { | |||
| * @param {String} [options.logFilename] - The name of the log file to search for in the iOS Simulator's "Documents" folder. This file is created after the app is started. | |||
| * @param {String} [options.simType=iphone] - The type of simulator to launch. Must be either "iphone" or "ipad". Only applicable when udid is not specified. | |||
| * @param {String} [options.simVersion] - The iOS version to boot. Defaults to the most recent version. | |||
| * @param {Number} [options.timeout] - Number of milliseconds to wait for the simulator to launch and launch the app before timing out. Ignored if not installing an app. | |||
| * @param {Number} [options.timeout=180] - Number of seconds to wait for the simulator to launch and launch the app before timing out. Defaults to 180. Minimum of 1. Ignored if not installing an app. | |||
There was a problem hiding this comment.
I'm a little concerned we are taking an existing flag that referred to milliseconds and replacing it with a timeout that refers to seconds. Why not keep it at milliseconds?
There was a problem hiding this comment.
It's a new flag as far as I'm concerned. This PR removes the timeout from JS (milliseconds) and uses ios-sim's built-in timeout (seconds) which is way more reliable. ios-sim passes the timeout directly into the simulator private APIs, which is in seconds, not milliseconds. Oh well.
There was a problem hiding this comment.
My only concern was backwards compatibility. If you don't think that's an issue, then no problem.
There was a problem hiding this comment.
This is a new API. It's not a problem.
|
APPROVED |
[TIMOB_17601] Added ioslib 0.2.9 which fixes handling of launch timeouts...
... and added extra debugging output. The default launch timeout is now 3 minutes which should be large enough for users launching an iOS 8 simulator on a really old, slow Mac. Added 'ios.simTimeout' config option to override the 3 minute default.