Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17797] iOS: added the floor property from CLFloor needed for geolocation #6176

Closed
wants to merge 1 commit into from

Conversation

Sophrinix
Copy link
Contributor

I've opened a Jira ticket: TC-4806

In iOS 8 Apple introduced some APIs for indoor geolocation.
See: https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLFloor_class/

There is also a slide deck from WWDC 2014 talking about this in more detail.
It is a trivial change, but a useful one.

The only down side is that finding a list of building that have been mapped by Apple is a difficult task.

@@ -130,6 +131,7 @@ -(void)requestSuccess:(NSString*)locationString
[event setObject:accuracy forKey:@"accuracy"];
[event setObject:latitude forKey:@"latitude"];
[event setObject:longitude forKey:@"longitude"];
//[event setObject:floor forKey:@"floor"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is commented? I guess that's not supposed to be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is spurious. I could do another pull request that fully implements it.

that actual code would have to look like

if([listItems count] == 4 && [[listItems objectAtIndex:0] isEqualToString:@"200"]) 
    {
        id accuracy = [listItems objectAtIndex:1];
        id latitude = [listItems objectAtIndex:2];
        id longitude = [listItems objectAtIndex:3];
        id floor = [listItems objectAtIndex:4];
        event = [TiUtils dictionaryWithCode:0 message:nil];
        [event setObject:accuracy forKey:@"accuracy"];
        [event setObject:latitude forKey:@"latitude"];
        [event setObject:longitude forKey:@"longitude"];
        [event setObject:floor  forKey:@"floor"];
    }

@ingo ingo changed the title added the floor property from CLFloor needed for geolocation [TIMOB-17797] added the floor property from CLFloor needed for geolocation Sep 29, 2014
@ingo
Copy link
Contributor

ingo commented Sep 29, 2014

Thank you for this. We will review it as soon as possible.

@ingo ingo changed the title [TIMOB-17797] added the floor property from CLFloor needed for geolocation [TIMOB-17797] iOS: added the floor property from CLFloor needed for geolocation Nov 17, 2014
@jonalter
Copy link
Contributor

Will be resolved by #6392

Thank you @Sophrinix

@jonalter jonalter closed this Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants