New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 5030: Android: Add support for HMAC SHA256 to mirror recent addition to iOS #618
Conversation
Hey Ping, I'm closing this pull request. It looks like your branch has a lot of revert commits, can you isolate the patch, create a new branch and submit a new pull request? |
Pull accepted- Tested on Nexus S 2.3.6, emulator 2.2 on both rhino and v8 sha256 of "The quick brown fox jumps over the lazy dog." should be "ef537f25c895bfa782526529a9b63d97aa631564d5d789c2b765448c8635fb6c" |
Hi marshall, I'm not sure how to do that. It seems all my branches have those revert Ping On 11/9/11 12:59 PM, "Marshall Culpepper"
|
fixed the revert commits and opened a new pull request #663 |
Timob 5030: Android: Add support for HMAC SHA256 to mirror recent addition to iOS
Steps to test:
run drillbit and test utils.
Added checks for the argument types, so should also solve timob-5863: Android: Missing null/undefined checks for some functions in android/modules/utils/UtilsModule.java