Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 5030: Android: Add support for HMAC SHA256 to mirror recent addition to iOS #618

Closed
wants to merge 12 commits into from

Conversation

pingwang2011
Copy link
Contributor

Timob 5030: Android: Add support for HMAC SHA256 to mirror recent addition to iOS

Steps to test:
run drillbit and test utils.

Added checks for the argument types, so should also solve timob-5863: Android: Missing null/undefined checks for some functions in android/modules/utils/UtilsModule.java

@marshall
Copy link
Contributor

marshall commented Nov 9, 2011

Hey Ping, I'm closing this pull request.

It looks like your branch has a lot of revert commits, can you isolate the patch, create a new branch and submit a new pull request?

@marshall marshall closed this Nov 9, 2011
@mpettiford
Copy link

Pull accepted-

Tested on Nexus S 2.3.6, emulator 2.2 on both rhino and v8

sha256 of "The quick brown fox jumps over the lazy dog." should be "ef537f25c895bfa782526529a9b63d97aa631564d5d789c2b765448c8635fb6c"
and was
"ef537f25c895bfa782526529a9b63d97aa631564d5d789c2b765448c8635fb6c"

@pingwang2011
Copy link
Contributor Author

Hi marshall,

I'm not sure how to do that. It seems all my branches have those revert
commits. I guess it's because those commits are in my master branch.

Ping

On 11/9/11 12:59 PM, "Marshall Culpepper"
reply@reply.github.com
wrote:

Hey Ping, I'm closing this pull request.

It looks like your branch has a lot of revert commits, can you isolate
the patch, create a new branch and submit a new pull request?


Reply to this email directly or view it on GitHub:
#618 (comment)
193

@pingwang2011
Copy link
Contributor Author

fixed the revert commits and opened a new pull request #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants