Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-17805][TIMOB-17806] Popover and Media Module refactor #6217

Merged
merged 12 commits into from Oct 14, 2014
Merged

[TIMOB-17805][TIMOB-17806] Popover and Media Module refactor #6217

merged 12 commits into from Oct 14, 2014

Conversation

vishalduggal
Copy link
Contributor

TIMOB-17805

  1. contentView is now a required property for Popover
  2. leftNavButton, rightNavButton and title properties now are NO-OPS
  3. popover moved from ViewProxy to TiProxy
  4. iOS8 refactor for popover presentation
    TIMOB-17806
  5. AudioSession replaced by AVAudioSession
  6. recordinginput event no longer fires.
  7. linechange event no longer fires. Replaced by the routechange event
  8. audioLineType deprecated. Replaced by currentRoute
  9. audioSessionMode deprecated. Replaced by audioSessionCategory
  10. iOS8 refactor for popover presentation

@vishalduggal vishalduggal mentioned this pull request Oct 14, 2014
Merged
@pec1985
Copy link
Contributor

pec1985 commented Oct 14, 2014

PR tested and reviewed. APPROVED!

pec1985 added a commit that referenced this pull request Oct 14, 2014
@pec1985
Merge pull request #6217 from vishalduggal/timob-17805
01803f9 
[TIMOB-17805][TIMOB-17806] Popover and Media Module refactor
@pec1985 pec1985 merged commit 01803f9 into tidev:master Oct 14, 2014
@vishalduggal vishalduggal deleted the timob-17805 branch October 27, 2014 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pec1985 pec1985

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vishalduggal @pec1985