[TIMOB-15612] Handle abort when submitting the request and handling respon... #6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sunil, I ran the 2nd test case in the ticket, not sure what is the expected behavior vs faulty behavior. Can you update the testing steps and what to look for when testing? Thanks, |
|
The issue was that, even though the request is aborted, onLoad was still called. This was fixed and onLoad shouldn't be called once it is aborted |
|
I took a look and tried it. onLoad doesn't get called. Looks good to me. |
ingo
changed the title
|
Looks good. Merging |
hieupham007
added a commit
that referenced
this pull request
Nov 17, 2014
[TIMOB-15612] Handle abort when submitting the request and handling respon...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-15612
Additional handling for abort when submitting the request and handling the response.