New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timob-17358]: Update Appcompat assets + scons #6247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KS does not work. Only black screen shows. |
The very first comment needs to be addressed. Need to add a null check for iconUrl. |
Functionally tested (used build tool 21.1.0):
|
CR + FR passed. Will merge after updating the doc. |
Doc reviewed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Nov 12, 2014
[Timob-17358]: Update Appcompat assets + scons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Update scons to build with Android-21
Update appcompat libraries and assets to run with Android-21
Update android projects to run with Android-21
Update theme.xml
Fix a crashing issue with the new libraries
Refactor Notification
Add Support for Material Theme
Implement category, priority, visibility properties for notification