Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17884]: Fix cache issues that affect android maps v2 #6256

Merged
merged 4 commits into from Oct 24, 2014

Conversation

hieupham007
Copy link
Contributor

This PR fixes the following tickets:
https://jira.appcelerator.org/browse/TIMOB-17877
https://jira.appcelerator.org/browse/TIMOB-17884
https://jira.appcelerator.org/browse/TIMOB-17085

Testing steps:

  1. If your project is already installed, please clear data and cache and uninstall it first
  2. Build a custom SDK using this branch, then use the zipped map updated in this PR to test
  3. You can test it with any basic maps, as indicated in the tickets themselves.

@hieupham007 hieupham007 changed the title [TIMOB-17884]: Add bounds check for cache [TIMOB-17884]: Fixes cache issues that affects android maps v2 Oct 22, 2014
@hieupham007 hieupham007 changed the title [TIMOB-17884]: Fixes cache issues that affects android maps v2 [TIMOB-17884]: Fix cache issues that affect android maps v2 Oct 22, 2014
@ghost
Copy link

ghost commented Oct 23, 2014

Hello, I tried to download the module and test it as instructed, however the TIMOB-17085 is still present and the map appears blurry.

@traviscrist
Copy link

Hello,

I downloaded the module and installed a build on my Nexus 5 & 7 both of which are running Android 5.0 L October Preview and TIMOB-17877 is still present. The map tiles do not load.

@jonalter
Copy link
Contributor

If we are updating the map module we need to submit a PR for the update to https://github.com/appcelerator-modules/ti.map and bump the version of the map module.

@hieupham007
Copy link
Contributor Author

Kifki and Travis, did you build this branch to test with the module updated in this PR? You need to do both for it to work. Just using the module in this PR won't solve the problem. Also, make sure you clear data and cache first THEN uninstall your existing app before re-installing it.

@traviscrist
Copy link

I did not build that branch when I tested out the fix this morning. I will
build it and check out if that with the new module resolves the problem on
Android 5.0 tomorrow morning. I will comment on this ticket with my results.

Travis

On Thursday, October 23, 2014, hieupham007 notifications@github.com wrote:

Kifki and Travis, did you build this branch to test with the module
updated in this PR. You need to do both for it to work. Just using the
module in this PR won't solve the problem.


Reply to this email directly or view it on GitHub
#6256 (comment)
.

@ghost
Copy link

ghost commented Oct 24, 2014

No, I didn't build the branch, I just used the module. Will report back as soon as I test again in the proper way.

@traviscrist
Copy link

Building the new SDK with the new module allows the map to load on my Nexus 5 running Android 5.0. I agree with jonalter that the module work need to be versioned as a new module and checked into the modules directory. Due to the dependency on this new TiSDK I would also recommend we up the minimum required TiSDK in the modules manifest file.

@jonalter
Copy link
Contributor

FT pass

jonalter added a commit that referenced this pull request Oct 24, 2014
[TIMOB-17884]: Fix cache issues that affect android maps v2
@jonalter jonalter merged commit 8e5602a into tidev:master Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants