[TIMOB-17894] iOS: Adds beta-reports-active to Entitlements.plist

[FokkeZB]

Only for App Store builds.

JIRA ticket: https://jira.appcelerator.org/browse/TC-4896

[ingo]

@cb1kenobi who else can review this?

[cb1kenobi]

@ingo Anybody on the iOS team.

[cb1kenobi]

CR'd, looks good. Needs FR.

[eric34]

Not seeing a file "Entitlements.plist" in the ipa. Is this change to the info.plist? Not seeing the key there either.

[FokkeZB]

@eric34 If your target is dist-appstore the build/iphone/Entitlements.plist should have the new key.

[eric34]

OK, So seeing "Entitlements.plist" with correct setting for beta-reports-active based on ad-hoc or app-store builds in the project "build/iphone" folder. iTunes connect set up, and will be conducting test to see if this works with test flight builds. Initially assumed the entitlements must be in the ipa.

[eric34]

PR: APPROVED
Please note I did see strange behavior from iTunes connect during this test, but feel confident enough for now to approve and then conduct additional (time consuming) tests to help understand the behavior we saw.

What I saw was this:

1. I created a project using sdk 3.4.1.GA and validated then pushed to iTunes connect. Users had been configured but I saw no App icon, no test flight toggle, and no link on the app version.
2. I then cleaned the project and built using a custom sdk including this fix. I pushed this to iTunes connect. Same result, no link, no toggle, no icon.
3. I waited a bit but nothing changed. A bit later I logged out and then logged back in.
4. At this point, both application versions (1.0.0 - Built with 3.4.1.GA, and 1.0.1 - built with this fix) allowed test flight. I selected 1.0.0 and distributed it to my "test team" (me) and was able to get the notification, and download, install, and launch the application.

So according to theory, the 1.0.0 version of my test application should not have had the entitlement as it was built with 3.4.1.GA. I will need to explore this more, but this will take some time as I will need to prepare two additional applications for upload. It could be that Apple is applying the provision to all versions of the app.

[ingo]

Approved. Merging.