[TIMOB-10755] CLI: "build" command for iOS modules #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Could you squash commits, please? ;) |
|
@cb1kenobi will you be reviewing this? |
|
@ingo Yep. |
ingo
changed the title
feons
force-pushed
the
TIMOB-10755
branch
2 times, most recently
from
24efce9
to
235b0ca
Compare
|
Attention: The contributor has signed the CLA |
feons
force-pushed
the
TIMOB-10755
branch
4 times, most recently
from
903cabf
to
c95599c
Compare
feons
force-pushed
the
TIMOB-10755
branch
2 times, most recently
from
353ab4c
to
61b6b65
Compare
|
FR passes, works as documented |
|
CR - looks good to me. @cb1kenobi can we merge? |
|
@skypanther I unfortunately do not have time to review. If you believe this PR is perfect, then merge away. |
|
|
||
| bindingMatch = bindingReg.exec(value); | ||
| if (bindingMatch != null) { | ||
| while (bindingMatch != null) { |
There was a problem hiding this comment.
This and preceding line, you should use !== unless you have a reason to be using !=
|
APPROVED |
skypanther
added a commit
that referenced
this pull request
Feb 12, 2015
[TIMOB-10755] CLI: "build" command for iOS modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-10755