[TIMOB-18027] iOS: Fix all dead store type error in static analyzer #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (txt.length == 0) { | ||
| txt = @" "; | ||
| if (ourView.text.length == 0) { | ||
| ourView.text = @" "; |
There was a problem hiding this comment.
Do not modify the value of the textArea text. This is legacy code. You can delete everything above the return value
|
Code looks good. Two minor comments. |
|
Closing this PR. The changes have been incorporated into PR #6357 which will be merged back to master soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead store errors are values assigned to variables during initialization that are never used or read. These should be removed.
JIRA: https://jira.appcelerator.org/browse/TIMOB-18027