[TIMOB-18028] iOS: Fix all memory leaks detected in static analyzer #6350
Conversation
2 errors remain
|
Thanks! How should this be tested? |
| @@ -29,7 +29,7 @@ @implementation GeolocationCallback | |||
|
|
|||
| -(id)initWithCallback:(KrollCallback*)callback_ context:(id<TiEvaluator>)context_ | |||
| { | |||
| if (self = [super init]) | |||
| if (self = [[super init] autorelease]) | |||
There was a problem hiding this comment.
Do NOT autorelease in an init function. ALWAYS balance releases with allocations.
You should ignore this analyzer warning. The GeolocationCallback objects implement APSHTTPRequestDelegate. Since the HTTPClient holds a weak reference to the delegate the delegate has to stay around till the request completes. The delegate will call autorelease on itself in either onLoad or onError (since one of them is guaranteed to be called). You can just put a comment in code that this analyzer warning can be ignored
|
Code reviewed. Please address comments. |
| @@ -192,7 +192,7 @@ -(NSNumber*)copy:(id)args | |||
| NSRange replacement = NSMakeRange(offset, MIN(MIN(sourceLength, [data length]-offset), [[sourceBuffer data] length]-sourceOffset)); | |||
| [data replaceBytesInRange:replacement withBytes:(source+sourceOffset)]; | |||
|
|
|||
| return NUMINT(replacement.length); | |||
| return [NUMINT(replacement.length) retain]; | |||
There was a problem hiding this comment.
Do not retain. You can ignore this analyzer warning
|
PR has been cherry-picked to the 3_5_0_64-bit branch which will be merged back to master soon. |
Static analyzer detects potential memory leak of objects. These should be checked and fixed when necessary.
JIRA: https://jira.appcelerator.org/browse/TIMOB-18028