[TIMOB-18079] Moved module detection and string hash function to base Bu... #6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Builder class to enable greater code reuse. Bumped Node.js engine support to 0.10.13 due to the introduction of const. Fixed small bug in Mobile Web build where 'android' was accidentally passed into validateAppJsExists(). Fixed potential issue with Mobile Web Windows Hybrid hook where the config was altered while detecting the Windows environment instead of afterwards. Cleaned up a bunch of inconsistencies across build commands.
|
I tested ti info, mobile web, and iOS and they're good so far. Still working on Android (I'm having sdk issues locally). |
|
Android's good too (finally!). I'll do another build and pass tomorrow morning when the updated fields commit hits. |
|
Ok, reran builds on iOS (iPhone 6 Plus simulator), Android (emulator, and Mobileweb and they all worked as expected. Good to merge. |
sgtcoolguy
added a commit
that referenced
this pull request
Nov 25, 2014
[TIMOB-18079] Moved module detection and string hash function to base Bu...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-18079