[TIMOB-18062] iOS: AttributedString Parity with Android #6463

ashcoding · 2014-12-10T08:49:32Z

Jira: https://jira.appcelerator.org/browse/TIMOB-18062

This PR is a continuation of #6409 which came from #6358.

It addresses the comments by @pingwang2011 for the Android portion of the code. The doc is still not completed yet as Titanium.UI.iOS.Attribute and Titanium.UI.iOS.AttributedString yml files are missing the "deprecated".

The propertyAccessors is now used in AttributedStringProxy.java, AttributeProxy.java and LabelProxy.java.

-Using property accessors in AttributedProxy for Range -Using property accessors in Label Proxy for AttributedString -Using property accessors in AttributedStringProxy for AttributedString

-Added attributed string for TextArea and TextField on Android -Added docs for TextArea and TextField

vishalduggal · 2014-12-11T16:29:01Z

iphone/Classes/TiUIiOSProxy.m

@@ -98,97 +98,6 @@ -(NSNumber*)CLIP_MODE_DISABLED
    return NUMINT(-1);
 }

-#ifdef USE_TI_UIIOSATTRIBUTEDSTRING
-MAKE_SYSTEM_PROP(ATTRIBUTE_FONT, AttributeNameFont);


These properties should not be deleted. Instead they should be marked DEPRECATED REPLACED

vishalduggal · 2014-12-11T16:49:01Z

TiUIAttributedStringProxy.m is only a member of Target Titanium-KitchenSink. It also needs to be added to target Titanium-KitchenSink-iPad and Titanium-KitchenSink-universal

vishalduggal · 2014-12-11T16:49:57Z

Code reviewed. Please address comments. Will do FR only after CR passes. As it stands right now this PR is rejected

matt-langston · 2014-12-11T18:12:05Z

@ashcoding, great work on this effort. I just noticed that 38 valuable comments from @pingwang2011 from PR #6409 pertain to this PR #6463. Will you please make sure those comments are addressed in this PR #6463? Here is the list of Ping's comments. Thank you!

pingwang2011 · 2014-12-11T19:01:26Z

For the question about duplicate properties, I meant:
{code}
var TEXT1 = 'Hello';
var TEXT2 = "Hi";

var attr = Titanium.UI.createAttributedString({
text: TEXT1,
attributes: [
//font
{
type: Ti.UI.ATTRIBUTE_FONT,
value: FONT1,
range: [0, text.length]
},
// Sets a background color
{
type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
value: COLOR1,
range: [0, text.length]
}
]
var label = Titanium.UI.createLabel({
text: TEXT2,
font: FONT2,
backgroundColor: COLOR2,
attributedString: attr
});
{code}

Which text (TEXT1 or TEXT2), font (FONT1 or FONT2) and backgroundColor (COLOR1 or COLOR2) will be respected?

ashcoding · 2014-12-12T02:02:45Z

android/modules/ui/src/java/ti/modules/titanium/ui/AttributedStringProxy.java

@@ -0,0 +1,58 @@
+/**
+ * Appcelerator Titanium Mobile
+ * Copyright (c) 2009-2014 by Appcelerator, Inc. All Rights Reserved.


#6409 (diff)

Fixed from 2013 to 2014

Probably should be 2014-2015, since 2014 is coming to an end.

@hieupham007 , you are farsighted 👍

pingwang2011 · 2014-12-15T21:09:10Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUILabel.java

+			if (attributedString instanceof AttributedStringProxy) {
+				Spannable spannableText = AttributedStringProxy.toSpannable(((AttributedStringProxy)attributedString), getProxy());
+				if (spannableText != null) {
+					((TextView)getNativeView()).setText(spannableText);


Use tv instead of ((TextView)getNativeView()).

pingwang2011 · 2014-12-15T21:55:13Z

In TextField and TextArea, if you set attributedString, font and backgroundColor initially, which properties will be applied for the user input text (the text input by soft keyboard)?

ashcoding · 2014-12-16T08:19:54Z

In TextField and TextArea, if you set attributedString, font and backgroundColor initially, which properties will be applied for the user input text (the text input by soft keyboard)?

The input text will use font and backgroundColor that is set if the input text is not in between the attributedString.

ashcoding · 2014-12-16T08:27:12Z

Sample Code.
Tab 1:-
It is a label with text "Appcelerator" as a link. You can click it and it will open a window.
Clicking the button will change the attributes.

Tab 2:-
First TextField has a normal input and an attributedStringHint. Erase the input to see the hint.

Second TextField has an AttributedString as input and background set to red, font color to yellow and size to 20. If you erase the AttributedString or type after it, the input will be yellow, font size 20 with red background. Background color affects both AttributedString and the input.

Third TextField has AttributedString and AttributedString hint. Erase it to reveal the hint.
Font has been set to size 10 and color red. If you type after or erase the AttributedString, the input will be size 10 and with color red.

Tab 3:-

TextArea has attributedString and font, color and backgroundColor set. If you erase the Attributed String or type after it, all the input text will be font 20, bold, yellow with red background. Background color affects both AttributedString and the input.

// this sets the background color of the master UIView (when there are no windows/tab groups on it)
Titanium.UI.setBackgroundColor('#000');
// create tab group
var tabGroup = Titanium.UI.createTabGroup();
// create base UI tab and root window
//////////////////////////////////////
var win1 = Titanium.UI.createWindow({  
    title:'Label',
    backgroundColor:'#ddd'
});
var tab1 = Titanium.UI.createTab({  
    icon:'KS_nav_views.png',
    title:'Label',
    window:win1
});


var text =  'Bacon ipsum dolor Appcelerator Titanium rocks! sit amet fatback leberkas salami sausage tongue strip steak.';

var attr = Ti.UI.createAttributedString({
    text: text,
    attributes: [
        //font
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: {font:{fontSize:50,fontFamily:'Helvetica Neue'}},
            range: [0, text.length]
        },
        // Underlines text
        {
            type: Ti.UI.ATTRIBUTE_UNDERLINES_STYLE,
            value: Ti.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [0, text.length]
        },
        // Sets a background color
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "red",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        }
    ]
});

attr.addAttribute(
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "blue",
            range: [text.indexOf('Titanium'), ('Titanium').length]
        }
);  

attr.addAttribute(
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "yellow",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        }
);        

attr.addAttribute(
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "orange",
            range: [0,  text.length]
        }
);

attr.addAttribute(
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "black",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        }
);

attr.addAttribute(
        {
            type: Ti.UI.ATTRIBUTE_LINK,//ignored in iOS, label doesn't support attribute link. Use textArea instead. 
            value: "http://www.appcelerator.com",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        }
);

var label = Titanium.UI.createLabel({
    left: 20,
    right: 20,
    height: Titanium.UI.SIZE,
    attributedString: attr
});

var changeStyle = Titanium.UI.createButton({
    bottom:200,
    title: "ChangeStyle"
});

win1.add(label);
win1.add(changeStyle);

var attr2 = Titanium.UI.createAttributedString({
    text: text,
    attributes: [
        //font
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: {font:{fontSize:30,fontFamily:'Helvetica Neue'}},
            range: [0, text.length]
        },
        // Underlines text
        {
            type: Ti.UI.ATTRIBUTE_UNDERLINES_STYLE,
            value: Ti.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [0, text.length]
        },
        // Sets a background color
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "green",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "red",
            range: [text.indexOf('Titanium'), ('Titanium').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "blue",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        },
        // Sets a foreground color
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "black",
            range: [0,  text.length]
        },
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "red",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        },
        // Sets strike through
        {
            type: Ti.UI.ATTRIBUTE_STRIKETHROUGH_STYLE,
            value: Titanium.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [text.indexOf('tongue'), ('tongue').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_LINK, //ignored in iOS, label doesn't support attribute link. Use textArea instead. 
            value: "http://www.appcelerator.com",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        }
    ]
});

changeStyle.addEventListener('click', function(){
    label.attributedString=attr2;});


//////////////////////////////////////
var win2 = Titanium.UI.createWindow({  
    title:'TextField',
    backgroundColor:'#ddd'
});
var tab2 = Titanium.UI.createTab({  
    icon:'KS_nav_views.png',
    title:'TextField',
    window:win2
});

var textFieldtextHint =  'Hints are awesome!';

var attrFieldHint = Ti.UI.createAttributedString({
    text: textFieldtextHint,
    attributes: [
        //font
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: {font:{fontSize:30,fontFamily:'Helvetica Neue'}},
            range: [0, textFieldtextHint.length]
        },
        // Underlines text
        {
            type: Ti.UI.ATTRIBUTE_UNDERLINES_STYLE,
            value: Ti.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [0, textFieldtextHint.length]
        },
        // Sets a background color
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "red",
            range: [textFieldtextHint.indexOf('Hints'), ('Hints').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "blue",
            range: [textFieldtextHint.indexOf('are'), ('are').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "yellow",
            range: [textFieldtextHint.indexOf('awesome!'), ('awesome!').length]
        },
        // Sets a foreground color
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "orange",
            range: [0,  textFieldtextHint.length]
        },
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "black",
            range: [textFieldtextHint.indexOf('awesome!'), ('awesome!').length]
        }
    ]
});

var textFieldtext =  'Textfields are awesome!';

var attrField = Ti.UI.createAttributedString({
    text: textFieldtext,
    attributes: [
        //font
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: {font:{fontSize:50,fontFamily:'Helvetica Neue'}},
            range: [0, textFieldtext.length]
        },
        // Underlines text
        {
            type: Ti.UI.ATTRIBUTE_UNDERLINES_STYLE,
            value: Ti.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [0, textFieldtext.length]
        },
        // Sets a background color
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "red",
            range: [textFieldtext.indexOf('Text'), ('Text').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "blue",
            range: [textFieldtext.indexOf('field'), ('field').length]
        },
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "yellow",
            range: [textFieldtext.indexOf('awesome!'), ('awesome!').length]
        },
        // Sets a foreground color
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "orange",
            range: [0,  textFieldtext.length]
        },
        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "black",
            range: [textFieldtext.indexOf('awesome!'), ('awesome!').length]
        }
    ]
});

var textField1 = Ti.UI.createTextField({
  borderStyle: Ti.UI.INPUT_BORDERSTYLE_ROUNDED,
  color: 'black',
  top: 10,
  width: 'auto', height: 'auto',
  value: 'value text',
  attributedHintText: attrFieldHint
});

var textField2 = Ti.UI.createTextField({
  borderStyle: Ti.UI.INPUT_BORDERSTYLE_ROUNDED,
  color: 'black',
  top: 110,
  width: 'auto', height: 'auto',
  attributedString: attrField,
  value: 'value text',
  font: {fontSize:20,fontFamily:'Helvetica Neue'},
  backgroundColor: 'red',
  color: 'yellow'

});

var textField3 = Ti.UI.createTextField({
  borderStyle: Ti.UI.INPUT_BORDERSTYLE_ROUNDED,
  color: 'black',
  top: 210,
  width: 'auto', height: 'auto',
  attributedHintText: attrFieldHint,
  attributedString: attrField,
  value: 'value text',
  font: {fontSize:10,fontFamily:'Helvetica Neue'},  
  color: 'red'
});

win2.add(textField1);
win2.add(textField2);
win2.add(textField3);

//////////////////////////////////////
var win3 = Titanium.UI.createWindow({  
    title:'TextArea',
    backgroundColor:'#ddd'
});
var tab3 = Titanium.UI.createTab({  
    icon:'KS_nav_views.png',
    title:'TextArea',
    window:win3
});

var textArea1 = Ti.UI.createTextArea({
  borderWidth: 2,
  borderColor: '#bbb',
  borderRadius: 5,
  textAlign: 'left',
  attributedString: attrField,
  value: 'value text',
  font: {fontSize:20, fontWeight:'bold'},
  backgroundColor: 'red',
  color: 'yellow',
  top: 10,
  width: 'auto', height: 'auto'
});

win3.add(textArea1);
//////////////////////////////////

tabGroup.addTab(tab1);  
tabGroup.addTab(tab2); 
tabGroup.addTab(tab3); 
// open tab group
tabGroup.open();

…ingProxy was added and other changes

pingwang2011 · 2015-01-05T22:58:46Z

Code reviewed. Left one comment about parity.
Ran the above sample code. It works as expected.

ingo · 2015-01-13T22:44:33Z

@ashcoding can you finish the review?

ashcoding · 2015-01-14T00:25:35Z

Will do.

ashcoding · 2015-01-14T03:41:28Z

iOS code needs to change for the color property. Sample code to show issue as follows:

// this sets the background color of the master UIView (when there are no windows/tab groups on it)
Titanium.UI.setBackgroundColor('#000');
//////////////////////////////////////
var win1 = Titanium.UI.createWindow({  
    title:'Label',
    backgroundColor:'#ddd'
});

var text =  'Bacon ipsum dolor Appcelerator Titanium rocks! sit amet fatback leberkas salami sausage tongue strip steak.';

var attr = Ti.UI.createAttributedString({
    text: text,
    attributes: [
        //font
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: {font:{fontSize:50,fontFamily:'Helvetica Neue'}},
            range: [0, text.length]
        },
        // Underlines text
        {
            type: Ti.UI.ATTRIBUTE_UNDERLINES_STYLE,
            value: Ti.UI.ATTRIBUTE_UNDERLINE_STYLE_SINGLE, //only iOS needs this, android ignores.
            range: [0, text.length]
        },
        // Sets a background color
        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "red",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        },

        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "blue",
            range: [text.indexOf('Titanium'), ('Titanium').length]
        },

        {
            type: Ti.UI.ATTRIBUTE_BACKGROUND_COLOR,
            value: "yellow",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        },

        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "orange",
            range: [0,  text.length]
        },

        {
            type: Ti.UI.ATTRIBUTE_FOREGROUND_COLOR,
            value: "black",
            range: [text.indexOf('rocks!'), ('rocks!').length]
        },

        {
            type: Ti.UI.ATTRIBUTE_LINK,//ignored in iOS, label doesn't support attribute link. Use textArea instead. 
            value: "http://www.appcelerator.com",
            range: [text.indexOf('Appcelerator'), ('Appcelerator').length]
        }

    ]
});


var label = Titanium.UI.createLabel({
    left: 20,
    right: 20,
    height: Titanium.UI.SIZE,
    attributedString: attr
});

//Changing the following properties shouldn't affect label as attributedString is respected first
label.text = "New text is here"; // This doesn't change on iOS and Android. Expected behavior.
label.setFont({fontSize:5}); // This doesn't change on iOS and Android. Expected behavior.
label.color = "red"; //iOS seems to be affected by this. Unexpected behavior.
//Shadow properties are working in iOS and Android. Doc should mention this.
label.shadowColor = "blue"; 
label.shadowRadius = 5;

win1.add(label);
win1.open();

cheekiatng · 2015-01-14T04:55:48Z

After some verification, existing iOS "attributedString"' behavior on UILabel is DIFFERENT from what the existing documents say.
if "attributedString" and other properties of UILabel is set initially, iOS respects the other properties. This has been confirmed. So there should no further changes to IOS behavior, and we will require Android to achieve parity with this behavior. Documents must also be updated to inform the correct behavior.
Thanks Ash.

ashcoding · 2015-01-14T04:57:55Z

I'll go change the Android behavior of the attributedString to match iOS when other properties is set.

ashcoding · 2015-01-14T07:36:23Z

I looked into this further.

In Android, if you set an attributed string, when you use methods such as setFont or setColor, natively it sets it to the Text in the TextView to those properties. If the AttributedString (natively it is SpannableString), those methods do not seem to change the properties of the AttributedString.

setColor, setFont and etc would affect the whole Text when used normally while normally when you use AttributedStrings, you would specify at which part does it have a certain color. Thus, I don't think it should be used in that way too.

So in this case, I would not recommend for parity in this case when AttributedString, text, color and font is used.

Instead I would recommend a document change to specify that you should not use AttributedString with the other properties, eg text, font and color in Android. Either use AttributedString or use the other properties.

Shadow properties work with no issue.

pingwang2011 · 2015-01-15T18:02:55Z

CR & FR passed for Android.
Please attach the test case to the JIRA ticket so QE can test it.

vishalduggal · 2015-01-15T18:35:40Z

I am going to accept this PR as is. There are some problems with the iOS implementation (formatting, un-required checks etc) but that will be fixed in a subsequent PR.

APPROVED

[TIMOB-18062] iOS: AttributedString Parity with Android

alexgbernier · 2015-04-10T16:46:54Z

Custom fonts don't appear to be working: https://jira.appcelerator.org/browse/AC-70

Chee Kiat Ng added 3 commits November 28, 2014 15:08

android attributedString

d8f4f3f

iOS AttributedString Parity

f51b6a8

project to include new class files

0e342e0

ashcoding mentioned this pull request Dec 10, 2014

[TIMOB-18062] iOS: AttributedString Parity with Android #6409

Closed

ashcoding force-pushed the TIMOB-18062 branch from 839ec27 to 89042bd Compare December 11, 2014 03:05

[TIMOB-18062] iOS and Android: AttributedString Parity

7354449

-Using property accessors in AttributedProxy for Range -Using property accessors in Label Proxy for AttributedString -Using property accessors in AttributedStringProxy for AttributedString

ashcoding force-pushed the TIMOB-18062 branch from 89042bd to 7354449 Compare December 11, 2014 03:10

ashcoding changed the title ~~TIMOB-18062~~ [TIMOB-18062] iOS: AttributedString Parity with Android Dec 11, 2014

[TIMOB-18062] iOS and Android: AttributedString Parity

fd7c5d3

-Added attributed string for TextArea and TextField on Android -Added docs for TextArea and TextField

vishalduggal reviewed Dec 11, 2014
View reviewed changes

ashcoding reviewed Dec 12, 2014
View reviewed changes

pingwang2011 reviewed Dec 15, 2014
View reviewed changes

ashcoding force-pushed the TIMOB-18062 branch 3 times, most recently from 48a912c to 447119d Compare December 16, 2014 09:21

[TIMOB-18062] Android: Missing addAttribute() method in AttributedStr…

d1cecab

…ingProxy was added and other changes

ashcoding force-pushed the TIMOB-18062 branch from 447119d to d1cecab Compare December 17, 2014 02:31

ashcoding force-pushed the TIMOB-18062 branch 2 times, most recently from 7e4b0d3 to d1cecab Compare January 14, 2015 05:38

[TIMOB-18062] Docs updated

124852b

ashcoding force-pushed the TIMOB-18062 branch from 2716f1d to 124852b Compare January 15, 2015 06:53

vishalduggal added a commit that referenced this pull request Jan 15, 2015

Merge pull request #6463 from ashcoding/TIMOB-18062

ab63641

[TIMOB-18062] iOS: AttributedString Parity with Android

vishalduggal merged commit ab63641 into tidev:master Jan 15, 2015

vishalduggal mentioned this pull request Jan 21, 2015

[TIMOB-18062] Cleanup iOS project #6592

Merged

ashcoding deleted the TIMOB-18062 branch May 21, 2015 07:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-18062] iOS: AttributedString Parity with Android #6463

[TIMOB-18062] iOS: AttributedString Parity with Android #6463

ashcoding commented Dec 10, 2014

vishalduggal Dec 11, 2014

vishalduggal commented Dec 11, 2014

vishalduggal commented Dec 11, 2014

matt-langston commented Dec 11, 2014

pingwang2011 commented Dec 11, 2014

ashcoding Dec 12, 2014

pingwang2011 Dec 15, 2014

hieupham007 Dec 15, 2014

pingwang2011 Dec 15, 2014

pingwang2011 Dec 15, 2014

pingwang2011 commented Dec 15, 2014

ashcoding commented Dec 16, 2014

ashcoding commented Dec 16, 2014

pingwang2011 commented Jan 5, 2015

ingo commented Jan 13, 2015

ashcoding commented Jan 14, 2015

ashcoding commented Jan 14, 2015

cheekiatng commented Jan 14, 2015

ashcoding commented Jan 14, 2015

ashcoding commented Jan 14, 2015

pingwang2011 commented Jan 15, 2015

vishalduggal commented Jan 15, 2015

alexgbernier commented Apr 10, 2015

[TIMOB-18062] iOS: AttributedString Parity with Android #6463

[TIMOB-18062] iOS: AttributedString Parity with Android #6463

Conversation

ashcoding commented Dec 10, 2014

vishalduggal Dec 11, 2014

Choose a reason for hiding this comment

vishalduggal commented Dec 11, 2014

vishalduggal commented Dec 11, 2014

matt-langston commented Dec 11, 2014

pingwang2011 commented Dec 11, 2014

ashcoding Dec 12, 2014

Choose a reason for hiding this comment

pingwang2011 Dec 15, 2014

Choose a reason for hiding this comment

hieupham007 Dec 15, 2014

Choose a reason for hiding this comment

pingwang2011 Dec 15, 2014

Choose a reason for hiding this comment

pingwang2011 Dec 15, 2014

Choose a reason for hiding this comment

pingwang2011 commented Dec 15, 2014

ashcoding commented Dec 16, 2014

ashcoding commented Dec 16, 2014

pingwang2011 commented Jan 5, 2015

ingo commented Jan 13, 2015

ashcoding commented Jan 14, 2015

ashcoding commented Jan 14, 2015

cheekiatng commented Jan 14, 2015

ashcoding commented Jan 14, 2015

ashcoding commented Jan 14, 2015

pingwang2011 commented Jan 15, 2015

vishalduggal commented Jan 15, 2015

alexgbernier commented Apr 10, 2015