Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct path to absolute path for test.db. #650

Merged
merged 1 commit into from Nov 9, 2011

Conversation

hieupham007
Copy link
Contributor

Android: Database - v8 only, Nook only, selecting pre-packaged Db causes Uncaught Error

@hieupham007
Copy link
Contributor Author

This fix is for TIMOB-6083.

@marshall
Copy link
Contributor

marshall commented Nov 9, 2011

Code and functional review accepted

@ayeung
Copy link
Contributor

ayeung commented Nov 9, 2011

Code reviewed. Request Accepted

@ayeung
Copy link
Contributor

ayeung commented Nov 9, 2011

Would be helpful to put repro steps in PR description, or link to jira ticket =)

@marshall
Copy link
Contributor

marshall commented Nov 9, 2011

+1 , we need to standardize on putting JIRA links in all pull requests. Repro steps are simply running KitchenSink > Database > pre-packaged DB

@marshall
Copy link
Contributor

marshall commented Nov 9, 2011

Link for posterity: http://jira.appcelerator.org/browse/TIMOB-6095

marshall added a commit that referenced this pull request Nov 9, 2011
Correct path to absolute path for test.db.
@marshall marshall merged commit 8ced176 into tidev:master Nov 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants