[TIMOB-18023]: Add rule for GPS + clean up listeners when app finish #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran the test case in JIRA. The Geo events are fired less frequently and the provider of all the events is always network. Is this behavior expected? Does this change need to be documented? |
|
You should see some GPS, is your phone getting GPS signals? You may have to enable it in settings or depends on where you're testing it, GPS signals may be blocked. |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Jan 6, 2015
[TIMOB-18023]: Add rule for GPS + clean up listeners when app finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA