[TIMOB-17754] Throw an event from webview

[ashcoding]

Jira: https://jira.appcelerator.org/browse/TIMOB-17754

[ashcoding]

Test code. Replace link with the ajax site you want to test with.
onLoadResource is available on all Android API level.

shouldInterceptRequest is only available on API level 11 aka Honeycomb devices. If used on Gingerbread (level 10), it won't be available.

var win = Ti.UI.createWindow();
//Please put a link with the ajax to test this
var webview = Titanium.UI.createWebView({url:'http://ajaxtoolbox.com/request/examples.php'});

webview.addEventListener('onLoadResource', function(e) {
Ti.API.info("onLoadResource Event Listener "+ e.url);
});

webview.addEventListener('shouldInterceptRequest', function(e) {
Ti.API.info("shouldInterceptRequest Event Listener " + e.url );
});

win.add(webview);
win.open();

[hieupham007]

'shouldInterceptRequest' event seems to return the same thing as 'onloadResource' event. Why do we need to fire 2 events back to back if they give the same information? Perhaps I'm missing something here? Also 'shouldInterceptRequest' event is deprecated in Lollipop, so I'm not sure we should add a feature that is already deprecated.

[ashcoding]

There's actually 2 versions of 'shouldInterceptRequest'.

'WebResourceResponse shouldInterceptRequest(WebView view, String url)' is deprecated from Lollipop.
'WebResourceResponse shouldInterceptRequest(WebView view, WebResourceRequest request)' is the new API available from Lollipop onwards to replace the deprecated one.

The 2 events fire on slightly different occasions but, at the end, for the user, it might be the same.
'shouldInterceptRequest' -> Notify the host application of a resource request
'onLoadResource' -> Notify the host application that the WebView will load the resource
Ref: http://developer.android.com/reference/android/webkit/WebViewClient.html

Thus, for this use case, would it be better to remove 'shouldInterceptRequest' and only use 'onLoadResource'? 'onLoadResource' would be cleaner too as it is available from API level 1. If so, I'll remove 'shouldInterceptRequest'.

[hieupham007]

I think 'onLoadResource' event is satisfactory. We shouldn't add any feature that is already deprecated.

[hieupham007]

Code reviewed and functionally tested. Please address comment

[hieupham007]

Can you elaborate on why this event needs to be synchronous?

[ashcoding]

This doesn't have to be synchronous. I'll change this.

[hieupham007]

Looks good functional, just a few minor comments

[hieupham007]

Looks good, merging