Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes switch animation on when programmatically setting value #6539

Closed
wants to merge 1 commit into from

Conversation

FokkeZB
Copy link
Contributor

@FokkeZB FokkeZB commented Jan 6, 2015

@hansemannn
Copy link
Collaborator

@FokkeZB Is this still happening? Would be happy to get this in.

@FokkeZB
Copy link
Contributor Author

FokkeZB commented Nov 10, 2015

Still true, but as you pointed out on Flow you wouldn't always want it not to animate so it would be better if we'd override setValue(val) to allow:

mySwitch.setValue(true, {
  animated: false
});

@skypanther
Copy link
Contributor

I commented on the ticket. Simply disabling the animation doesn't fully resolve the current problem with the switch.

@hansemannn
Copy link
Collaborator

Closed in favor of #7456

@hansemannn hansemannn closed this Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants