New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing @Kroll.method so that createBroadcastIntent is callable. #655
Conversation
Code review accepted. Thanks for this! Have you signed our CLA? |
No, how do I do that? |
go to our e-signing page for the CLA and comment here when you've signed it. We can then activate it on our end and accept the pull request. Thanks! |
ok, done. |
By the power vested in me, I now pronouce you ready to contribute code to Titanium. You may now merge the pull request. |
I've opened this issue to track the pull request: |
Just out of curiosity, where you able to use this with an external broadcast receiver once you exposed the method? |
I have not tried it as I am not setup to compile the code. On Tue, Nov 15, 2011 at 3:46 PM, Marshall Culpepper <
|
A simple build / test would help in knowing if this API actually solves a problem (we may need to expose other APIs on top of this one to make broadcast intents generally useful). Can you give this a build and let us know if it works out for you? |
@perfectapi bumping -- are you still interested in getting this merged? As far as I can tell exposing this method won't actually resolve the issue in Q&A. Would you be willing to make that change as well? |
@perfectapi Closing this for now, AFAICT we will need to further expose |
Fixes http://developer.appcelerator.com/question/127953/unable-to-create-a-broadcast-intent-for-android