Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing @Kroll.method so that createBroadcastIntent is callable. #655

Closed
wants to merge 1 commit into from
Closed

Added missing @Kroll.method so that createBroadcastIntent is callable. #655

wants to merge 1 commit into from

Conversation

@marshall
Copy link
Contributor

Code review accepted. Thanks for this! Have you signed our CLA?

@ghost
Copy link
Author

ghost commented Nov 10, 2011

No, how do I do that?

@kwhinnery
Copy link
Contributor

go to our e-signing page for the CLA and comment here when you've signed it. We can then activate it on our end and accept the pull request. Thanks!

@ghost
Copy link
Author

ghost commented Nov 10, 2011

ok, done.

@kwhinnery
Copy link
Contributor

By the power vested in me, I now pronouce you ready to contribute code to Titanium. You may now merge the pull request.

@ghost ghost closed this Nov 10, 2011
@ghost ghost reopened this Nov 10, 2011
@marshall
Copy link
Contributor

I've opened this issue to track the pull request:
http://jira.appcelerator.org/browse/TIMOB-6142

@marshall
Copy link
Contributor

Just out of curiosity, where you able to use this with an external broadcast receiver once you exposed the method?

@ghost
Copy link
Author

ghost commented Nov 15, 2011

I have not tried it as I am not setup to compile the code.

On Tue, Nov 15, 2011 at 3:46 PM, Marshall Culpepper <
reply@reply.github.com

wrote:

Just out of curiosity, where you able to use this with an external
broadcast receiver once you exposed the method?


Reply to this email directly or view it on GitHub:

#655 (comment)

@marshall
Copy link
Contributor

A simple build / test would help in knowing if this API actually solves a problem (we may need to expose other APIs on top of this one to make broadcast intents generally useful). Can you give this a build and let us know if it works out for you?

http://wiki.appcelerator.org/display/guides/How+to+Contribute+Code#HowtoContributeCode-CompilingtheCode

@marshall
Copy link
Contributor

marshall commented Mar 3, 2012

@perfectapi bumping -- are you still interested in getting this merged?

As far as I can tell exposing this method won't actually resolve the issue in Q&A. Activity.sendBroadcast will also need to be exposed to allow the sending of broadcast intents:
http://developer.android.com/reference/android/content/Context.html#sendBroadcast(android.content.Intent)

Would you be willing to make that change as well?

@marshall
Copy link
Contributor

@perfectapi Closing this for now, AFAICT we will need to further expose Activity.sendBroadcast to make this contribution useful. Please re-open or send a new PR if you are still interested in getting this in :)

@marshall marshall closed this Mar 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants