[TIMOB-18399] Windows: Projects can not be deleted if it's built once #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FR failed. I'm still unable to delete the project (enable the option to delete from disk as well) after it is run on Android device. The delete failed as it was unable to delete build_android.log file. |
| @@ -315,7 +317,7 @@ function patchLogger(logger, cli) { | |||
| // log it to our log file, stripping out the color codes | |||
| logger.log.filestream.write('\n' + prefix + (args.length > 2 ? sprintf.apply(null, args.slice(1)) : args[1]).replace(/\x1B\[\d+m/g, '')); | |||
| } else { | |||
| logger.log.buffer += '\n' + prefix + args[1].replace(/\x1B\[\d+m/g, ''); | |||
| !logger.fileWriteEnabled && (logger.log.buffer += '\n' + prefix + args[1].replace(/\x1B\[\d+m/g, '')); | |||
There was a problem hiding this comment.
You are trying to buffer the data only if the fileWriteEnabled is false. Why do you need to buffer the data if we close the file stream, but probably never open it again ?
Shouldn't the entire block be guarded against fileWriteEnabled condition ?
|
FR passed. |
|
CR passed. |
pinnamur
pushed a commit
that referenced
this pull request
Jan 30, 2015
[TIMOB-18399] Windows: Projects can not be deleted if it's built once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-18399